D21542: Ignore Okteta part if there is an external application available

[Friedrich W. H. Kossebau]

kossebau added a comment.


  What is so wrong with hex editor previews? Spot your trojans while they enter your system in a zip !;)
  
  More serious: I am not sure if users want a full-blown application started instead of the previewer.  Even more if this cannot be foreseen when triggering the preview, what actually will happen.
  I would rather expect no preview if there is no (wanted) previewer available. And have a dedicated "Open" instead.

INLINE COMMENTS

> arkviewer.cpp:236
>          offers = KMimeTypeTrader::self()->query(mimeType, QStringLiteral("Application"));
> +    } else if (offers.count() == 1 && offers.constFirst()->desktopEntryName() == QLatin1String("oktetapart")) {
> +        const auto appOffers = KMimeTypeTrader::self()->query(mimeType, QStringLiteral("Application"));

Perhaps other than hardcoding "oktetapart" one might want to catch services which support the mimetype "application/octet-stream". So do something like (untested)

  offers.constFirst()->mimeTypes() == QStringList(QStringLiteral(""application/octet-stream"))

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D21542

To: elvisangelaccio, #ark, #vdg, rthomsen, kossebau
Cc: aacid, kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190602/c9058abb/attachment.html>