D21637: Display BLAKE2 file checksums for RAR files

[N. Higa]

nhiga added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in archivemodel.cpp:188
> I wonder if we could use a more descriptive string here. "BLAKE2" will be meaningless to most users. Maybe "Checksum" ?

I did not include the word "checksum" for BLAKE2 because I wanted to follow the example of "CRC". But it is true that CRC is more well-known than BLAKE2. Which of the following option is better in your opinion?

1. Add the word "checksum" to both CRC and BLAKE2:

          case CRC:
  	​            return i18nc("CRC hash code", "CRC checksum");
  ​        case BLAKE2:
  	​            return i18nc("BLAKE2 hash code", "BLAKE2 checksum");

2. Add the word "checksum" to BLAKE2 only:

          case CRC:
  	​            return i18nc("CRC hash code", "CRC");
  ​        case BLAKE2:
  	​            return i18nc("BLAKE2 hash code", "BLAKE2 checksum");

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D21637

To: nhiga, #ark, elvisangelaccio
Cc: #ark, kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190718/639f4b05/attachment.html>