D18256: Remember part URL to delete the tempfile even if the user used save as.

David Faure noreply at phabricator.kde.org
Mon Jan 14 22:14:19 GMT 2019


dfaure created this revision.
dfaure added reviewers: elvisangelaccio, broulik.
Herald added a subscriber: kde-utils-devel.
Herald added a project: Ark.
dfaure requested review of this revision.

REVISION SUMMARY
  Using the part URL at closing time is really dangerous: if the user used
  "save as" (e.g. for an embedded PDF), we'll be deleting the file that
  the user just saved!!
  
  BUG: 402529

TEST PLAN
  launch ARK and open a ZIP file containing a PDF, click on the PDF,
  an embedded viewer appears. From there, use "Save As..." to save the PDF
  somewhere on your local disk. Close the embedded viewer, close ark.
  It doesn't delete the saved file anymore.

REPOSITORY
  R36 Ark

BRANCH
  Applications/18.12

REVISION DETAIL
  https://phabricator.kde.org/D18256

AFFECTED FILES
  part/arkviewer.cpp
  part/arkviewer.h

To: dfaure, elvisangelaccio, broulik
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190114/54856b2e/attachment.html>


More information about the Kde-utils-devel mailing list