D18854: Allow changing the foreground/text color of buttons
Christoph Feck
noreply at phabricator.kde.org
Sat Feb 23 14:28:44 GMT 2019
cfeck added inline comments.
INLINE COMMENTS
> cfeck wrote in kcalc.cpp:2080
> No need to create a color scheme twice. Please reuse `schemeButtons` for button and text color.
I didn't want you to remove the complete code. If the colors are not changed, no style sheets should be set. See bug 237513.
> cfeck wrote in kcalc_button.cpp:167
> textColor() returns a QColor, so the cast is not needed.
Better modify a local QColor variable before setting. This way you can remove the setEnabled() overload.
REPOSITORY
R353 KCalc
REVISION DETAIL
https://phabricator.kde.org/D18854
To: thiagoneves, cfeck, tcanabrava
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190223/ae47b925/attachment.html>
More information about the Kde-utils-devel
mailing list