D26288: Use "QFontDatabase::FixedFont" instead of some font just "Monospace"

Thomas Fischer noreply at phabricator.kde.org
Mon Dec 30 12:34:33 GMT 2019


thomasfischer created this revision.
thomasfischer requested review of this revision.

REVISION SUMMARY
  File `src/manager/walletwidget.ui` specifies font "Monospace" to use for showing passwords. However, in case there is a font called "Monospace" installed on the system, this will be used instead of the default/system fixed-width font. If the "Monospace" font is broken or rendered incorrectly, passwords cannot be read from within the wallet manager.
  
  To fix this problem, set a fixed font in C++ code by invoking `setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont))` which uses the fixed-width font as configured by the user.

TEST PLAN
  1. Get a font called "Monospace" which is not your default fixed-width font. Observe that this font is used to show passwords
  2. Apply patch, recompile and restart KWalletManager
  3. Observe that the correct fixed-width font is used

REPOSITORY
  R362 KWalletManager

REVISION DETAIL
  https://phabricator.kde.org/D26288

AFFECTED FILES
  src/manager/kwalleteditor.cpp
  src/manager/walletwidget.ui

To: thomasfischer
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191230/5742dd27/attachment.html>


More information about the Kde-utils-devel mailing list