D23403: Fix authentication

[Nicolas Fella]

nicolasfella created this revision.
Herald added a subscriber: kde-utils-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  According to the CUPS code (https://github.com/apple/cups/blob/master/cups/auth.c#L105) cupsDoAuthentication returns 0 on success and -1 on error. The code was assuming the opposite
  
  Now the CUPS password dialog is shown when needed. This is quite often, e.g directly at startup due to getServerSettings() so it might be worth checking if that's really necessary.
  
  BUG: 408512

TEST PLAN
  Open print-manager with a user that is not in a CUPS system group. Privileged operations work after entering a password

REPOSITORY
  R363 Print Manager

BRANCH
  twist

REVISION DETAIL
  https://phabricator.kde.org/D23403

AFFECTED FILES
  libkcups/KCupsConnection.cpp

To: nicolasfella
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190824/5d4da094/attachment.html>