D22983: Fix build with cmake < 3.7
Wolfgang Bauer
noreply at phabricator.kde.org
Wed Aug 7 10:29:13 BST 2019
wbauer created this revision.
wbauer added a project: Ark.
Herald added subscribers: Ark, kde-utils-devel.
wbauer requested review of this revision.
REVISION SUMMARY
`VERSION_GREATER_EQUAL` was introduced in cmake 3.7, but the specified minimum version is 3.0.
So use `VERSION_LESS` instead (and swap the branches) to still support older cmake versions too.
TEST PLAN
Builds fine with cmake 3.5.2 now, and also newer versions.
The file is still installed to ${KDE_INSTALL_LOGGINGCATEGORIESDIR} when building with latest KF5 from git, haven't tried older versions.
Before, I got this error when using cmake 3.5.2:
CMake Error at CMakeLists.txt:108 (if):
if given arguments:
"ECM_VERSION" "VERSION_GREATER_EQUAL" "5.59.0"
Unknown arguments specified
REPOSITORY
R36 Ark
REVISION DETAIL
https://phabricator.kde.org/D22983
AFFECTED FILES
CMakeLists.txt
To: wbauer
Cc: kde-utils-devel, #ark, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190807/33d1e33b/attachment-0001.html>
More information about the Kde-utils-devel
mailing list