D20683: Get columns to show from first file entry

Elvis Angelaccio noreply at phabricator.kde.org
Mon Apr 22 17:12:06 BST 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> archivemodel.cpp:543
>  {
> +    qSort(m_showColumns);
> +

`qSort()` is deprecated, please use `std::sort()` instead.

> archivemodel.cpp:545
> +
> +    qCDebug(ARK) << "Showing columns: " << m_showColumns;
> +

Please move this debug line within the if block below. If the archive fails to open, there are no columns to show.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D20683

To: rthomsen, elvisangelaccio, nhiga
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190422/818bbe76/attachment.html>


More information about the Kde-utils-devel mailing list