D15463: Corrected behaviour on repeated pressing of operator buttons

Albert Astals Cid noreply at phabricator.kde.org
Thu Sep 20 20:56:03 BST 2018


aacid added inline comments.

INLINE COMMENTS

> kcalc_core.h:110
>  
> +    bool only_update_operation_;
> +

I'm not sure we have much people to agree/disagree if this is how it should work, but let's fix style issues first :)

Please don't make a public member variable, use getter/setter like the rest of the code does.

REPOSITORY
  R353 KCalc

REVISION DETAIL
  https://phabricator.kde.org/D15463

To: mschiller, cfeck, teran, #kde_applications
Cc: aacid, cfeck, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180920/09d2392c/attachment.html>


More information about the Kde-utils-devel mailing list