D15445: Use Ark part only when mime type exactly matches a supported type

Elvis Angelaccio noreply at phabricator.kde.org
Sun Sep 16 16:57:31 BST 2018


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Looks good otherwise

INLINE COMMENTS

> arkviewer.cpp:221-223
> +    // Use the Ark part only when the mime type matches an archive type directly.
> +    // Many file types (e.g. Open Document) are technically just archives
> +    // but browsing their internals is typically not what the user wants.

Please move this comment below, it's a bit confusing here (because it doesn't explain what the `find_id` call does).

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D15445

To: broulik, #ark, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180916/75b852a2/attachment.html>


More information about the Kde-utils-devel mailing list