D15369: Add support for Zstd-compressed Tar-archives

Yuri Chornoivan noreply at phabricator.kde.org
Tue Nov 6 19:18:48 GMT 2018


yurchor added inline comments.

INLINE COMMENTS

> readwritelibarchiveplugin.cpp:355
> +#ifdef HAVE_ZSTD_SUPPORT
> +    } else if (filename().rightRef(3).compare(QLatin1String("zst"), Qt::CaseInsensitive) {
> +        qCDebug(ARK) << "Detected zstd compression for new file";

Maybe it is better to use the old-style comparison without c++17 features? It breaks the compilation on oldish gccs:

https://build.kde.org/job/Applications/job/ark/job/kf5-qt5%20SUSEQt5.9/65/consoleFull

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D15369

To: rthomsen, elvisangelaccio, dakon
Cc: yurchor, dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20181106/3544baca/attachment-0001.html>


More information about the Kde-utils-devel mailing list