D15369: Add support for Zstd-compressed Tar-archives

[Rolf Eike Beer]

dakon requested changes to this revision.
dakon added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:9
>  
> +if(LibArchive_VERSION VERSION_EQUAL "3.3.3" OR
> +    LibArchive_VERSION VERSION_GREATER "3.3.3")

if(NOT LibArchive_VERSION VERSION_LESS 3.3.3)

> CMakeLists.txt:57
>  
> +if(LibArchive_VERSION VERSION_EQUAL "3.3.3" OR
> +    LibArchive_VERSION VERSION_GREATER "3.3.3")

Again.

> CMakeLists.txt:75
>  
> +if(LibArchive_VERSION VERSION_EQUAL "3.3.3" OR
> +    LibArchive_VERSION VERSION_GREATER "3.3.3")

Again. Maybe create a boolean flag if zstd support should be enabled?

> readwritelibarchiveplugin.cpp:351
>          requiresExecutable = true;
> -        } else if (filename().right(3).toUpper() == QLatin1String("LZ4")) {
> -            qCDebug(ARK) << "Detected lz4 compression for new file";
> -            ret = archive_write_add_filter_lz4(m_archiveWriter.data());
> +    } else if (filename().right(3).toUpper() == QLatin1String("LZ4")) {
> +        qCDebug(ARK) << "Detected lz4 compression for new file";

filename().rightRef(3).compare(QLatin1String("lz4"), Qt::CaseInsensitive)

> readwritelibarchiveplugin.cpp:355
> +#ifdef HAVE_LIBARCHIVE_3_3_3
> +    } else if (filename().right(3).toUpper() == QLatin1String("ZST")) {
> +        qCDebug(ARK) << "Detected zstd compression for new file";

Again.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D15369

To: rthomsen, elvisangelaccio, dakon
Cc: dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20181103/1b439729/attachment.html>