D12769: Resolve decryption failure when message has no version header

[Rolf Eike Beer]

dakon requested changes to this revision.
dakon added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kgpgdecrypt.cpp:119
> +	}
>  	if (!inputFiles.isEmpty()) {
>  		if (line == QLatin1String("[GNUPG:] BEGIN_DECRYPTION")) {

This can become "} else if…", none of the following code can be run in this call as all check line again for different values.

> kgpgdecrypt.h:85
>  	const QString m_outFilename;	///< name of file to write output to
> +	bool decryptSuccess = false; //< flag to determine if decryption succeeded
>  };

You probably do not need this variable, you  can directly call setSuccess() when you receive the line.

REPOSITORY
  R358 KGpg

REVISION DETAIL
  https://phabricator.kde.org/D12769

To: kavindap, dakon
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180509/9a68f338/attachment.html>