D11188: Fix use after free in RadialMap::Widget::invalidate()

Szymon Janus noreply at phabricator.kde.org
Fri Mar 9 18:46:03 UTC 2018


janus created this revision.
Restricted Application added a subscriber: kde-utils-devel.
janus requested review of this revision.

REVISION SUMMARY
  Emit aboutToEmptyCache to invoke RadialMap::Widget::invalidate(),
  so folder can be safely deleted.
  
  If "Scan across system boundaries" isn't set and there is mountpoint B
  contained in another mountpoint A, user may trigger segfault if scan of
  A and then B is requested. It is caused by call of MainWindow class to
  m_map->invalidate() method, which is invoked after m_map's m_tree member
  is deleted during ScanManager::start method.
  
  This fix causes that RadialMap::Widget::invalidate() is called twice in
  fact, however second call is fine, because "invalidate" is guarded by
  "isValid" method.
  
  BUG: 389119

REPOSITORY
  R352 Filelight

REVISION DETAIL
  https://phabricator.kde.org/D11188

AFFECTED FILES
  src/scan.cpp

To: janus
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180309/50dea85e/attachment.html>


More information about the Kde-utils-devel mailing list