D14844: [CompressFileItemAction] Don't offer for non-local URLs

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Aug 14 16:55:18 BST 2018


broulik created this revision.
broulik added reviewers: elvisangelaccio, dfaure.
Herald added subscribers: Ark, kde-utils-devel.
Herald added a project: Ark.
broulik requested review of this revision.

REVISION SUMMARY
  We pass `%F` to `ark` command which means "multiple local paths".
  `KFileItemListProperties::isLocal()` doesn't see that `desktop:/foo` is a link to a local file, so doing it manually here.

TEST PLAN
  - Compressing single and multiple local files still works
  - Compressing files on `desktop:/` still works
  - Entry no longer shows up for `desktop:/` itself as it cannot compress that anyway

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D14844

AFFECTED FILES
  app/compressfileitemaction.cpp

To: broulik, elvisangelaccio, dfaure
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180814/4de176ad/attachment.html>


More information about the Kde-utils-devel mailing list