D14510: Add --mimetypes command line option

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Thanks for the patch. Just a couple of small nitpicks, looks good otherwise.

INLINE COMMENTS

> main.cpp:197
>  
> +    parser.addOption(QCommandLineOption(QStringList() << QStringLiteral("mimetypes"),
> +                                        i18n("List supported MIME types.")));

Please add also the short version, i.e. `QStringLiteral("m")`

> main.cpp:313
> +            QTextStream cout(stdout);
> +            for (const auto &mimeType: mimeTypes) {
> +                cout << mimeType << '\n';

Please add a space before `:`

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D14510

To: volkov, #ark, elvisangelaccio
Cc: elvisangelaccio, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180804/6d735c30/attachment.html>