D8299: libzip: Preserve modtime when extracting

Ragnar Thomsen noreply at phabricator.kde.org
Sun Oct 15 17:44:40 UTC 2017


rthomsen marked 3 inline comments as done.
rthomsen added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in libzipplugin.cpp:555
> Use `QT_STAT`. Also, the filename should be passed to `QFile::encodeName()`.
> 
> I'm wondering if we can just use `QFileInfo::lastModified()` instead?

`QFileInfo::lastModified()` returns a `QDateTime`, but we need a `time_t` for the `utime()` call.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D8299

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20171015/6e60be07/attachment.html>


More information about the Kde-utils-devel mailing list