D8294: Improve layout in previewer

Ragnar Thomsen noreply at phabricator.kde.org
Sat Oct 14 14:18:27 UTC 2017


rthomsen marked an inline comment as done.
rthomsen added inline comments.

INLINE COMMENTS

> arkviewer.cpp:175
>      // Set icon and comment for the mimetype.
> -    m_iconLabel->setPixmap(QIcon::fromTheme(mimeType.iconName()).pixmap(IconSize(KIconLoader::Desktop), IconSize(KIconLoader::Desktop)));
> +    m_iconLabel->setPixmap(QIcon::fromTheme(mimeType.iconName()).pixmap(16, 16));
>      m_commentLabel->setText(mimeType.comment());

Is it ok to hardcode these sizes?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D8294

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20171014/0bd6111b/attachment.html>


More information about the Kde-utils-devel mailing list