D8941: do not misuse QGroupBox as a layout helper, instead use a layout directly

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: sandsmark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  QGB with some styles has very unfortunate rendering if it has no title
  nor frame configured. e.g. with the windows 9x style it renders the top
  border line assuming there is a title even when there is none.
  Ultimately we do not need QGB here at all though as we have it entirely
  hidden and only use it as glorified layout container. So, replace QGB with
  a Layout directly. Reduces excess code, memory footprint and fixes
  appearance with various styles.
  
  (technically we could put the entire setup into the designer file and
   do away with the QButtonGroup as radios are autoexclusive with other
   radios in the same parenting qwidget anyway; seems unncessarily invasive
   though)

TEST PLAN
  no more silly line artifact with windows 9x style; breeze continues to look stelar

REPOSITORY
  R352 Filelight

BRANCH
  no-color-groupbox

REVISION DETAIL
  https://phabricator.kde.org/D8941

AFFECTED FILES
  src/dialog.ui
  src/settingsDialog.cpp

To: sitter, sandsmark
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20171122/65d8a2d2/attachment.html>