D5869: Fix crash when renaming top-level entries

Elvis Angelaccio noreply at phabricator.kde.org
Mon May 15 15:55:25 UTC 2017


elvisangelaccio created this revision.
Restricted Application added subscribers: Ark, kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  After commit https://phabricator.kde.org/R36:7781d6ef794a8da9afe1c837c3a7826103568add, the model of the archive view changed to the
  filter model. So we were asking `m_model` to get an index from
  `currentIndex`, which instead belongs to `m_filterModel`.
  
  Since the model usage here is pointless (current index = child of the
  parent of the current index... why?), just remove the code.
  
  BUG: 379802
  FIXED-IN: 17.04.2

TEST PLAN
  Renaming top-level entries doesn't crash anymore. Renaming child entries still works.

REPOSITORY
  R36 Ark

BRANCH
  bug/379802 (branched from Applications/17.04)

REVISION DETAIL
  https://phabricator.kde.org/D5869

AFFECTED FILES
  part/part.cpp

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170515/ec0c59fa/attachment.html>


More information about the Kde-utils-devel mailing list