[Differential] [Request, 40 lines] D4000: Properly kill AddToArchive jobs

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Sat Jan 7 12:25:06 UTC 2017


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  Both AddToArchive and CreateJob are wrapper jobs, they need to implement
  doKill() and call kill() on the actual jobs that are doing the work.
  
  BUG: 374433
  FIXED-IN: 16.12.1

TEST PLAN
  Compress a big folder from Dolphin, stop job from system tray. Crash is gone.

REPOSITORY
  R36 Ark

BRANCH
  bug/374433

REVISION DETAIL
  https://phabricator.kde.org/D4000

AFFECTED FILES
  kerfuffle/addtoarchive.cpp
  kerfuffle/addtoarchive.h
  kerfuffle/jobs.cpp
  kerfuffle/jobs.h
  plugins/libarchive/libarchiveplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170107/f47930e2/attachment.html>


More information about the Kde-utils-devel mailing list