[Differential] [Requested Changes] D4692: Fix deprecation warning for KRun::runUrl()

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> batchextract.cpp:173
>              destination.setPath(QDir::cleanPath(destination.path()));
> -            KRun::runUrl(destination, QStringLiteral("inode/directory"), 0);
> +            KRun::runUrl(destination, QStringLiteral("inode/directory"), Q_NULLPTR, KRun::RunExecutables, QString(), QByteArray());
>          }

You can remove the last two arguments, they already take a default value

> part.cpp:1035
>                           QMimeDatabase().mimeTypeForFile(fullName).name(),
> -                         widget(), false, false);
> +                         widget(), 0, QString(), QByteArray());
>          }

Use `KRun::RunFlags()` rather than 0. And same as above, you can drop the last 2 arguments

> part.cpp:1265
>  
> -            KRun::runUrl(destinationDirectory, QStringLiteral("inode/directory"), widget());
> +            KRun::runUrl(destinationDirectory, QStringLiteral("inode/directory"), widget(), KRun::RunExecutables, QString(), QByteArray());
>          }

Same here, QString() and QByteArray not necessary

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D4692

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170220/bd6c0610/attachment.html>