[Differential] [Request, 11 lines] D4536: Fix archivemodel columns with singlefile archives

Elvis Angelaccio noreply at phabricator.kde.org
Thu Feb 9 18:25:23 UTC 2017


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added subscribers: Ark, kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  ArchiveModel was setting 0 as Size with singlefile archives,
  because the singlefile plugin doesn't report the uncompressed size.
  
  This patch removes the Size column if the size property is 0 but the
  compressedSize one is higher than 0, which cannot happen.
  As compressedSize for singlefile entries, we just set the size of the
  archive.
  
  BUG: 376225
  FIXED-IN: 16.12.3

TEST PLAN
  Open a gzipped file and check the columns in the archiveview, with/without
  patch.

REPOSITORY
  R36 Ark

BRANCH
  Applications/16.12

REVISION DETAIL
  https://phabricator.kde.org/D4536

AFFECTED FILES
  part/archivemodel.cpp
  plugins/libsinglefileplugin/singlefileplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170209/ed6379ba/attachment.html>


More information about the Kde-utils-devel mailing list