[Differential] [Requested Changes To] D2811: Refactor archive loading

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Tue Sep 27 08:33:51 UTC 2016


rthomsen requested changes to this revision.
rthomsen added a comment.
This revision now requires changes to proceed.


  This is a huge commit. I've briefly glanced through it, but didn't notice any errors as such. Tested opening/modifying various archive formats. Some comments:
  
  - I can confirm that the endless loop is gone :)
  - The extraction dialog now appears instantly when using the batch switch on a large archive. However, it is disabled (gray) until the listjob/loadjob completes. This is the intented behavior, right?
  - One thing I noticed: The KMessageWidget no longer disappears after adding a file to a new archive.
  - Why are the new jobs in another source file?

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2811

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160927/bc2ae403/attachment.html>


More information about the Kde-utils-devel mailing list