[Differential] [Request, 7 lines] D2868: Improve focus handling of internal previewer
rthomsen (Ragnar Thomsen)
noreply at phabricator.kde.org
Tue Sep 27 06:31:28 UTC 2016
rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.
REVISION SUMMARY
This diff sets the initial focus of the internal previewer to the Part widget and sets the autodefault property of the Close button to false. The latter prevents the Enter key from closing the dialog which allows the Part widget to handle the key press event instead.
Fixes two bugs:
Bug 369401 <https://bugs.kde.org/show_bug.cgi?id=369401>
Bug 369390 <https://bugs.kde.org/show_bug.cgi?id=369390>
Meant for 16.08 branch.
TEST PLAN
1. Open any archive and preview a file with internal previewer.
2. Check that the Part widget has focus.
3. Check that the Enter key doesn't close the dialog.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D2868
AFFECTED FILES
part/arkviewer.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160927/66646630/attachment.html>
More information about the Kde-utils-devel
mailing list