[Differential] [Request, 10 lines] D2852: Fix potential crash when aborting a ListJob in libarchive plugin

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to rARK Ark.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  Libarchive's error() signal is connected to the `Job::onError` slot, but when we abort a ListJob, the slot might be called when the job instance has already been deleted. So let's emit this signal only when we are not aborting the job.
  
  BUG: 369283
  FIXED-IN: 16.08.2

TEST PLAN
  For some reason, this crash is hard to reproduce (it happened only a couple of times to me). This is surprising because looking at the code I would expect a crash every time...

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2852

AFFECTED FILES
  plugins/libarchive/libarchiveplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160925/f8d4f1bb/attachment.html>