[Differential] [Request, 41 lines] D3217: Simplify Query usage in CLI plugins

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Mon Oct 31 17:02:08 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  CliInterface-based plugins run from the main thread, so there is no need to
  emit the `userQuery` signal and then call `Query::waitForResponse()`.
  They can directly call `Query::execute()` instead.
  
  Also improve the apidox about this and add a warning
  in case we forgot in the future.

TEST PLAN
  Try to use a query from a cli plugin (e.g. open an header-encrypted rar
  archive).

REPOSITORY
  rARK Ark

BRANCH
  cleanup-queries

REVISION DETAIL
  https://phabricator.kde.org/D3217

AFFECTED FILES
  kerfuffle/archiveinterface.h
  kerfuffle/cliinterface.cpp
  kerfuffle/jobs.cpp
  kerfuffle/queries.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161031/cf893756/attachment.html>


More information about the Kde-utils-devel mailing list