Review Request 129225: KCalc : Renamed Shift button to 2nd-Function

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129225/#review100141
-----------------------------------------------------------



-1

Please no hardcoded stylesheets/colors

If you really want only the Shift button have a different color, you could split it from the "Functions" color group on the settings page.

Regarding the naming, my CASIO fx-350MS actually says "SHIFT" (and uses a yellow text color).

- Christoph Feck


On Oct. 19, 2016, 6:40 p.m., Paul McQuade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129225/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 6:40 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: kcalc
> 
> 
> Description
> -------
> 
> KCalc : Renamed Shift button to 2nd-Function
> 
> Changed shift button to 2nd-F due to most
> calculators having one. It's also colour orange.
> 
> 
> Diffs
> -----
> 
>   kcalc.cpp c5c4bf4 
>   kcalc.ui 16e2ca6 
> 
> Diff: https://git.reviewboard.kde.org/r/129225/diff/
> 
> 
> Testing
> -------
> 
> Builds on Manjaro 16.08.
> 
> 
> Thanks,
> 
> Paul McQuade
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161019/f64f6920/attachment.html>