[Differential] [Request, 14 lines] D3074: Allow extraction of read-only archives

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Sun Oct 16 17:09:55 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  We use `KFileItemListProperties::supportsWriting()` to check whether a folder
  is read-write and can be used as extract destination, but this function returns
  false if the archive is read-only. A read-only archive can still be extracted,
  so we need to implement our own check for the writability of parent folders.

TEST PLAN
  Check that https://bugs.kde.org/show_bug.cgi?id=370948 is fixed.
  Check that the action is still disabled in read-only folders.

REPOSITORY
  rARK Ark

BRANCH
  read-only-extractions

REVISION DETAIL
  https://phabricator.kde.org/D3074

AFFECTED FILES
  app/extractfileitemaction.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161016/7e2815d1/attachment.html>


More information about the Kde-utils-devel mailing list