[Differential] [Request, 106 lines] D3072: Show progress in percentage for all job types in LibarchivePlugin

[rthomsen (Ragnar Thomsen)]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  Progress is now also shown in percentage for `Addjob`, `CopyJob`, `DeleteJob` and `MoveJob` for archives handled by LibarchivePlugin. This was a bit tricky due to libarchive always iterating the whole archive and means that the plugin needs to know the total number of existing archive entries.
  
  Two new properties were added to the `CompressionOptions` class: `NumberOfEntriesToAdd` and `NumberOfExistingEntries`. The first one is only set for `AddJob`, while the latter is used for all of these job types.
  
  DeleteJob ctor got an additional argument of type `CompressionOptions` to hold the `NumberOfExistingEntries` value.

TEST PLAN
  Run the four job types:
  
  - AddJob (try adding files both to an empty archive and an existing archive)
  - CopyJob
  - DeleteJob
  - MoveJob
  
  And check that progress is shown in percentage in the status bar.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3072

AFFECTED FILES
  autotests/kerfuffle/jobstest.cpp
  autotests/kerfuffle/jsonarchiveinterface.cpp
  autotests/kerfuffle/jsonarchiveinterface.h
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archiveinterface.h
  kerfuffle/cliinterface.cpp
  kerfuffle/cliinterface.h
  kerfuffle/jobs.cpp
  kerfuffle/jobs.h
  kerfuffle/options.cpp
  kerfuffle/options.h
  plugins/clizipplugin/cliplugin.cpp
  plugins/libarchive/libarchiveplugin.cpp
  plugins/libarchive/libarchiveplugin.h
  plugins/libarchive/readwritelibarchiveplugin.cpp
  plugins/libarchive/readwritelibarchiveplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161016/37cbd5aa/attachment.html>