[Differential] [Accepted] D2987: Detect compression method

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Sun Oct 9 16:16:42 UTC 2016


elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> libarchiveplugin.cpp:542
> +        return QStringLiteral("GZip");
> +    } else if (method == QLatin1String("bzip2")) {
> +        return QStringLiteral("BZip2");

These `else` are not really necessary since they come after a return, but i guess this is a subjective style preference. Up to you :p

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2987

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161009/7d5aa383/attachment.html>


More information about the Kde-utils-devel mailing list