[Differential] [Request, 34 lines] D2948: Process entries while listing archives
rthomsen (Ragnar Thomsen)
noreply at phabricator.kde.org
Wed Oct 5 18:46:32 UTC 2016
rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.
REVISION SUMMARY
Currently, when listing archives Ark waits until the LoadJob is done to process the entries. This causes a lag (>7 seconds for large archives on fast systems) after the LoadJob has completed until the ArchiveView is ready.
This diff causes ArchiveModel to start processing entries while the LoadJob is running. This results in the view being ready <1 second after LoadJob completes.
To avoid the view showing a partially loaded archive while LoadJob runs, we set the model of the view to Q_NULLPTR and in Part::slotLoadingFinished() set it to m_model again.
TEST PLAN
1. Open a large archive.
2. Check that there is no long delay after LoadJob completes until the view is ready.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D2948
AFFECTED FILES
part/archivemodel.cpp
part/archivemodel.h
part/part.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161005/39852365/attachment.html>
More information about the Kde-utils-devel
mailing list