[Differential] [Requested Changes To] D2879: Support for setting compression method

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  What about createdialogtest? Does it make sense to check whether the new widget is enabled/disabled?

INLINE COMMENTS

> addtoarchivetest.cpp:70
>  
> +
>      QTest::newRow("compress here (as TAR) - dir with subdirs")

This file has only empty lines as changes.

> cliinterface.cpp:1047-1074
> +QString CliInterface::compressionMethodSwitch(const QString &method, const QString &archive) const
> +{
> +    if (method.isEmpty()) {
> +        return QString();
> +    }
> +
> +    Q_ASSERT(m_param.contains(CompressionMethodSwitch));

What about making this method virtual? This way each plugin could implement it and provide whatever switch they prefer.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2879

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161004/e4a3e544/attachment.html>