[Differential] [Request, 2 lines] D2909: Fix drag-and-drop extraction of parentless files

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Sat Oct 1 19:06:03 UTC 2016


rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  In some archives parent folders of some files might not be part of the archive themselves, i.e. the archive does not contain entries for them. In this case ArchiveModel creates ArchiveDirNodes for these folders. However, the FileName and InternalID properties of these folders do not get a trailing slash. This results in faulty root nodes leading to e.g. broken drag-n-drop extraction of files within these folders.
  
  This diff simply appends a traling slash to the properties.
  
  Solves bug:
  https://bugs.kde.org/show_bug.cgi?id=367549

TEST PLAN
  1. Open an archive which contains parentless files, e.g. the nested tar.gz archive within the attached archive in: https://bugs.kde.org/show_bug.cgi?id=367549
  2. Drag-and-drop extract e.g. the file `etc/nsswitch.conf`

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2909

AFFECTED FILES
  part/archivemodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161001/48ef87ad/attachment.html>


More information about the Kde-utils-devel mailing list