[Differential] [Request, 15 lines] D2905: Fix extraction of selected entries from AppImage
rthomsen (Ragnar Thomsen)
noreply at phabricator.kde.org
Sat Oct 1 12:28:05 UTC 2016
rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.
REVISION SUMMARY
Extraction of selected entries from AppImages is curently broken on master. This is because when libarchive lists the AppImage all entries are prepended with "./", which results in entry paths not matching those supplied by Part.
The unittests didn't catch this because there is only one testcase for AppImage in which alle entries are extracted. A new testcase which triggers the bug was added.
Applications/16.08 branch is somehow not affected.
TEST PLAN
1. Open any AppImage.
2. Extract (or preview) selected entries.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D2905
AFFECTED FILES
autotests/kerfuffle/extracttest.cpp
plugins/libarchive/libarchiveplugin.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161001/c4def783/attachment.html>
More information about the Kde-utils-devel
mailing list