[Differential] [Request, 20 lines] D3527: pluginmanager: cache list of preferred plugins
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Mon Nov 28 11:58:11 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.
REVISION SUMMARY
PluginManager::preferredPluginsFor() is an hot path as it can be called
thousands of times from the extractfileitemaction plugin.
We can save the list of preferred plugins in a cache, instead of
re-computing it over and over again.
BUG: 372999
FIXED-IN: 16.11.90
TEST PLAN
Tested in Dolphin by right-clicking:
- 1K files: no delay
- 10K files: ~1 sec. of delay
- 50K files: ~4 sec. of delay
The (empty) test files were created with:
printf '%s ' {1..1000} | xargs touch
REPOSITORY
R36 Ark
BRANCH
bug/372999
REVISION DETAIL
https://phabricator.kde.org/D3527
AFFECTED FILES
kerfuffle/pluginmanager.cpp
kerfuffle/pluginmanager.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161128/7c66ff6e/attachment.html>
More information about the Kde-utils-devel
mailing list