[Differential] [Requested Changes To] D3142: Improve error handling for CliPlugins

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cliplugin.cpp:98
>  {
> -    Q_UNUSED(line)
> +    QVector<QRegularExpression> rxList {QRegularExpression(QStringLiteral("Failed! \\((.+)\\)$")),
> +                                        QRegularExpression(QStringLiteral("Segmentation fault$"))};

Let's remove the "Segmentation fault" pattern so you don't have to use a QVector here.

> cliplugin.cpp:114
> +    QVector<QRegularExpression> rxList {QRegularExpression(QStringLiteral("Failed! \\((.+)\\)$")),
> +                                        QRegularExpression(QStringLiteral("Segmentation fault$"))};
> +

Same, drop "Segmentation fault"

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3142

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161113/e44f14c3/attachment-0001.html>