Review Request 129352: Port to QStandardPaths
Elvis Angelaccio
elvis.angelaccio at kde.org
Sat Nov 12 19:01:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129352/#review100804
-----------------------------------------------------------
Fix it, then Ship it!
privacyfunctions.cpp (line 176)
<https://git.reviewboard.kde.org/r/129352/#comment67654>
QLatin1String is better than QStringLiteral when concatenating
- Elvis Angelaccio
On Nov. 9, 2016, 9:13 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129352/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2016, 9:13 p.m.)
>
>
> Review request for KDE Utils.
>
>
> Repository: sweeper
>
>
> Description
> -------
>
> Port to QStandardPaths
>
>
> Diffs
> -----
>
> CMakeLists.txt 05e82ef
> config-sweeper.h.cmake PRE-CREATION
> privacyfunctions.cpp 902a697
>
> Diff: https://git.reviewboard.kde.org/r/129352/diff/
>
>
> Testing
> -------
>
> Builds. Checked that kio_http_cache_cleaner --clear-all gets executed and that KBookmarkManager gets passed the actual path to konqueror's bookmarks.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161112/47876ea3/attachment-0001.html>
More information about the Kde-utils-devel
mailing list