Review Request 129365: add encryption methods

Elvis Angelaccio elvis.angelaccio at kde.org
Fri Nov 11 10:29:56 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129365/#review100773
-----------------------------------------------------------




File Attachment: create-protected-archive.png - create-protected-archive.png
<https://git.reviewboard.kde.org//r/129365/#fcomment606>

    What about splitting this screenshot into 3 different ones? Each one would have only one section expanded (Compression, Password Protection and Multi-volume Archive)



doc/index.docbook (line 339)
<https://git.reviewboard.kde.org/r/129365/#comment67647>

    Technically only zip and *only with the p7zip backend*, but I supposed this can be omitted since p7zip is supposed to be the default. Btw we should also add a warning messagewidget in the dialog, since a zip with AES256 encryption cannot be unpacked by infozip's unzip.
    
    Not sure if this should be in the docbook...



doc/index.docbook (line 341)
<https://git.reviewboard.kde.org/r/129365/#comment67646>

    Missing trailing period.


- Elvis Angelaccio


On Nov. 9, 2016, 8:46 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129365/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 8:46 p.m.)
> 
> 
> Review request for Documentation, KDE Utils, Elvis Angelaccio, and Ragnar Thomsen.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> see summary
> update screenshot
> remove obsolete menuitem "Add Folder"
> 
> 
> Diffs
> -----
> 
>   doc/create-protected-archive.png abdec5d 
>   doc/index.docbook 0b9516e 
> 
> Diff: https://git.reviewboard.kde.org/r/129365/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> File Attachments
> ----------------
> 
> create-protected-archive.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/11/09/45cda3df-d54d-4f66-a470-378763393c80__create-protected-archive.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161111/1f48ebfc/attachment.html>


More information about the Kde-utils-devel mailing list