[Differential] [Request, 536 lines] D3303: Implement support for setting encryption method

[rthomsen (Ragnar Thomsen)]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  Needed infrastructure changes were done in ArchiveFormat, CliProperties and
  other classes. A combobox was added to CreateDialog which enables setting the
  encryption method.
  
  Currently, only the Zip format when using cli7z supports multiple encryption
  methods. For other formats that support only one encryption method, the method
  is shown in the combobox.
  
  This diff also enables detection of encryption method when opening archives
  which is then shown in PropertiesDialog. To this end a new signal was added to
  ReadOnlyArchiveInterface (encryptionMethodFound). The similar
  compressionMethodFound signal was modified to only take one string instead of
  QStringList.

TEST PLAN
  Create pasword-protected Zip archive with cli7z and choose different encryption
  methods. Verify that the selected method is used.
  Check that correct encryption method is shown in PropertiesDialog when opening
  various encrypted archives.

REPOSITORY
  rARK Ark

BRANCH
  encmethod (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3303

AFFECTED FILES
  app/mainwindow.cpp
  autotests/plugins/cli7zplugin/cli7ztest.cpp
  autotests/plugins/cli7zplugin/data/archive-zip-AES256-1602.txt
  autotests/plugins/clirarplugin/clirartest.cpp
  autotests/plugins/clizipplugin/cliziptest.cpp
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archive_kerfuffle.h
  kerfuffle/archiveformat.cpp
  kerfuffle/archiveformat.h
  kerfuffle/archiveinterface.h
  kerfuffle/cliinterface.cpp
  kerfuffle/cliproperties.cpp
  kerfuffle/cliproperties.h
  kerfuffle/compressionoptionswidget.cpp
  kerfuffle/compressionoptionswidget.h
  kerfuffle/compressionoptionswidget.ui
  kerfuffle/createdialog.cpp
  kerfuffle/createdialog.h
  kerfuffle/options.cpp
  kerfuffle/options.h
  kerfuffle/propertiesdialog.cpp
  part/part.cpp
  plugins/cli7zplugin/cliplugin.cpp
  plugins/cli7zplugin/cliplugin.h
  plugins/cli7zplugin/kerfuffle_cli7z.json.cmake
  plugins/clirarplugin/cliplugin.cpp
  plugins/clirarplugin/cliplugin.h
  plugins/clirarplugin/kerfuffle_clirar.json.cmake
  plugins/cliunarchiverplugin/cliplugin.cpp
  plugins/clizipplugin/cliplugin.cpp
  plugins/clizipplugin/cliplugin.h
  plugins/clizipplugin/kerfuffle_clizip.json.cmake
  plugins/libarchive/libarchiveplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161107/d642b712/attachment.html>