[Differential] [Requested Changes To] D3235: CliInterface refactoring

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cliplugin.h:58
>  private:
> -
> +    void setupCliProperties();
>      void readJsonOutput();

One more thing: since all cli plugins need this method, make it virtual and call in just once in the CliInterface ctor

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3235

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161104/8acc6f2f/attachment.html>