[Differential] [Requested Changes To] D3235: CliInterface refactoring

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> cliinterface.h:54-58
> -    /**
> -     * Bool (default false)
> -     * Will look for the %-sign in the stdout while working, in the form of
> -     * (2%, 14%, 35%, etc etc), and report progress based upon this
> -     */

Maybe we should keep the docs in this enum. You can move them above the Q_PROPERTY they end up in.

> cliinterface.h:146
> +     */
> +    virtual QString escapeFileName(const QString &fileName) const;
> +

This method can be moved back to the private section.

> cliproperties.h:81-109
> +    QStringList addArgs(const QString &archive,
> +                        const QStringList &files,
> +                        const QString &password,
> +                        bool headerEncryption,
> +                        int compressionLevel,
> +                        const QString &compressionMethod,
> +                        uint volumeSize);

All the methods of the new class can be marked as `const` , it seems.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3235

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161104/c7be5976/attachment.html>