Review Request 128883: Update ark docbook to 16.12

Ragnar Thomsen rthomsen6 at gmail.com
Wed Nov 2 19:00:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128883/#review100511
-----------------------------------------------------------




doc/index.docbook (line 187)
<https://git.reviewboard.kde.org/r/128883/#comment67452>

    There are also filename checks, which prevent usage of illegal characters such as /, . and .. in filenames.



doc/index.docbook (line 207)
<https://git.reviewboard.kde.org/r/128883/#comment67453>

    remove "implemented"



doc/index.docbook (line 212)
<https://git.reviewboard.kde.org/r/128883/#comment67454>

    This action can be used to add files at any location within the archive.



doc/index.docbook (line 213)
<https://git.reviewboard.kde.org/r/128883/#comment67455>

    "selected  destination" -> "selected folder"



doc/index.docbook (lines 214 - 215)
<https://git.reviewboard.kde.org/r/128883/#comment67456>

    This is unclear. Can't we simpley write: "Otherwise, the new files will be added to the root of the archive."



doc/index.docbook (line 329)
<https://git.reviewboard.kde.org/r/128883/#comment67457>

    "select the compression method - with different options for each of these archive types" -> "select between different compression methods."
    
    Also, can we add something like:
    "Note that using compression methods other than the pre-selected defaults may limit compatiblity with file archivers. For example, opening Zip archives with compression methods other than Deflate requires newer archiving software.


- Ragnar Thomsen


On Oct. 31, 2016, 8:20 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128883/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2016, 8:20 p.m.)
> 
> 
> Review request for KDE Utils, Elvis Angelaccio and Ragnar Thomsen.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> add infos about ark GSOC project
> content from 
> http://mvlabat.github.io/ark-gsoc-2016/tasks/2016/08/17/finishing-my-gsoc-project.html
> and
> https://community.kde.org/GSoC/2016/StatusReports/Batyrenko_Vladyslav
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook f75f058 
> 
> Diff: https://git.reviewboard.kde.org/r/128883/diff/
> 
> 
> Testing
> -------
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161102/b775fed6/attachment.html>


More information about the Kde-utils-devel mailing list