Review Request 128059: Don't close the remove view if preferences are not shown

Urs Wolfer uwolfer at kde.org
Tue May 31 19:29:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128059/#review96107
-----------------------------------------------------------


Ship it!




Ship It!

- Urs Wolfer


On May 30, 2016, 4:16 p.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128059/
> -----------------------------------------------------------
> 
> (Updated May 30, 2016, 4:16 p.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> The user already made it quite clear that he wants to open the remove view if we're here, so don't close it again if he selected not to show the preferences dialog which is an option in the preferences dialog itself, BTW...
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128059/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160531/7f073c12/attachment.html>


More information about the Kde-utils-devel mailing list