Review Request 128032: Fix command line argument handling

[Arno Möller]

> On May 29, 2016, 10:39 a.m., Urs Wolfer wrote:
> > mainwindow.cpp, line 305
> > <https://git.reviewboard.kde.org/r/128032/diff/4/?file=467221#file467221line305>
> >
> >     I prefer this also in an separate change since it is not closelry related to the first issue, right?

OK, done. See https://git.reviewboard.kde.org/r/128059/


> On May 29, 2016, 10:39 a.m., Urs Wolfer wrote:
> > main.cpp, line 122
> > <https://git.reviewboard.kde.org/r/128032/diff/4/?file=467220#file467220line122>
> >
> >     Don't you think this logic could remain here?
> 
> Arno Möller wrote:
>     Not really. MainWindow::newConnection() will bail out if it can't handle the scheme, anyway.
> 
> Urs Wolfer wrote:
>     Right, the "continue" block is not required. But the "recover" logic which adds "vnc://" protocol by default could still be useful?
> 
> Arno Möller wrote:
>     Why? How can we possibly know that the user wanted a vnc:// connection? It's just a good guess...
> 
> Urs Wolfer wrote:
>     Right, but this would be better for backward compatibilty. As the comment says, it's so since KDE 3 times ;)

I revised the patch some more and created a new review request for this:
https://git.reviewboard.kde.org/r/128060/

Should I discard this one?


- Arno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/#review95973
-----------------------------------------------------------


On May 29, 2016, 10:34 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128032/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 10:34 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> * Use QUrl::fromUserInput() for parsing command line arguments
> * Bail out MainWindow::newConnection() if we don't have a plugin for the requested URL
> * Ignore the return value from showDialogIfNeeded(). Since we're already there, the user made quite clear that he wants to see the view, either by passing it via the command line or typing it into the new connection bar.
> 
> 
> Diffs
> -----
> 
>   main.cpp 73093f3 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128032/diff/
> 
> 
> Testing
> -------
> 
> Invoke:
> $ krdc rdp://<your.favorite.rdp.host>
> 
> Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
> With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab.
> With both patches krdc works as expected.
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160530/08a22a78/attachment.html>