Review Request 128032: Fix command line argument handling

[Arno Möller]

> On May 29, 2016, 10:39 a.m., Urs Wolfer wrote:
> > main.cpp, line 122
> > <https://git.reviewboard.kde.org/r/128032/diff/4/?file=467220#file467220line122>
> >
> >     Don't you think this logic could remain here?

Not really. MainWindow::newConnection() will bail out if it can't handle the scheme, anyway.


- Arno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/#review95973
-----------------------------------------------------------


On May 29, 2016, 10:34 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128032/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 10:34 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> * Use QUrl::fromUserInput() for parsing command line arguments
> * Bail out MainWindow::newConnection() if we don't have a plugin for the requested URL
> * Ignore the return value from showDialogIfNeeded(). Since we're already there, the user made quite clear that he wants to see the view, either by passing it via the command line or typing it into the new connection bar.
> 
> 
> Diffs
> -----
> 
>   main.cpp 73093f3 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128032/diff/
> 
> 
> Testing
> -------
> 
> Invoke:
> $ krdc rdp://<your.favorite.rdp.host>
> 
> Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
> With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab.
> With both patches krdc works as expected.
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160529/86d976cc/attachment.html>