Review Request 128042: Don't shut down the current view after saving the preferences

[Urs Wolfer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128042/#review95975
-----------------------------------------------------------


Ship it!




Thanks a lot! Can you please commit this to the latest stable branch?

- Urs Wolfer


On May 29, 2016, 10:50 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128042/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 10:50 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> No need to close the current view after saving preferences for the host.
> It's actually harmful. MainWindow::saveHostPrefs() is called after app.exec(), closing the current view.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128042/diff/
> 
> 
> Testing
> -------
> 
> $ krdc rdp://<your.favorite.host>
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160529/749abf34/attachment.html>