Review Request 128032: Fix command line argument handling

[Urs Wolfer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/#review95966
-----------------------------------------------------------




main.cpp (line 119)
<https://git.reviewboard.kde.org/r/128032/#comment64899>

    This cannot be done this way. Protocol support is implemented via plugins. If you hardcode it here, the whole gain of the plugin architecture is lost.



main.cpp (line 123)
<https://git.reviewboard.kde.org/r/128032/#comment64900>

    Please add a space after if (here and below also).



mainwindow.cpp (line 302)
<https://git.reviewboard.kde.org/r/128032/#comment64901>

    Can you please move this to a separate change? I prefer to have one change in one commit.
    
    Also, I'm not sure if this correct. Before it returned. With your change, the result of #showDialogIfNeeded is ignored.



mainwindow.cpp 
<https://git.reviewboard.kde.org/r/128032/#comment64902>

    Strange... Have you analyzed Git history to check why this was here?


- Urs Wolfer


On May 29, 2016, 8:43 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128032/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 8:43 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> * Don't treat an URL passwd via the command line as a local file. That gives us file://rdp://<something or other>, which is garbage.
> * Don't shut down the view when the user chose not to show the preference dialog for the host
> * Also don't close the view on MainWindow::saveHostPrefs()
> 
> 
> Diffs
> -----
> 
>   main.cpp 73093f3 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128032/diff/
> 
> 
> Testing
> -------
> 
> Invoke:
> $ krdc rdp://<your.favorite.rdp.host>
> 
> Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
> With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab.
> With both patches krdc works as expected.
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160529/e5f1e9ce/attachment-0001.html>