Review Request 128032: Fix command line argument handling

[Arno Möller]

> On May 29, 2016, 8:11 a.m., Elvis Angelaccio wrote:
> > The 3 patches are unrelated from each other, right? Ideally you should open a review for each atomic patch

Well, they fix different issues, but they are related somehow:

Without the 1. patch, krdc converts every URL to vnc://
With the 1. patch, but without the 2., the view is closed immediately if the user chose not to see the preferences for the host passed via the command line
The 3. patch prevents the view from being closed when MainWindow::saveHostPrefs() is called. That makes no sense. That slot is called right after app.exec(), so the view is created, but instantly closed after startup.
The 4. patch implements your suggestions.

What do you think: 3 separate review requests or just one?


- Arno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/#review95964
-----------------------------------------------------------


On May 29, 2016, 7:59 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128032/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 7:59 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> * Don't treat an URL passwd via the command line as a local file. That gives us file://rdp://<something or other>, which is garbage.
> * Don't shut down the view when the user chose not to show the preference dialog for the host
> * Also don't close the view on MainWindow::saveHostPrefs()
> 
> 
> Diffs
> -----
> 
>   main.cpp 73093f3 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128032/diff/
> 
> 
> Testing
> -------
> 
> Invoke:
> $ krdc rdp://<your.favorite.rdp.host>
> 
> Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
> With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab.
> With both patches krdc works as expected.
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160529/db0fa527/attachment.html>