Review Request 128032: Fix command line argument handling

[Arno Möller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128032/
-----------------------------------------------------------

(Updated May 29, 2016, 7:59 a.m.)


Review request for KDE Utils and Urs Wolfer.


Changes
-------

Next iteration of this patchset.
No functional changes.
Make command line argument handling more obvious: Check the URL against a whitelist of supported schemes.


Repository: krdc


Description (updated)
-------

* Don't treat an URL passwd via the command line as a local file. That gives us file://rdp://<something or other>, which is garbage.
* Don't shut down the view when the user chose not to show the preference dialog for the host
* Also don't close the view on MainWindow::saveHostPrefs()


Diffs (updated)
-----

  main.cpp 73093f3 
  mainwindow.cpp dd1d8a0 

Diff: https://git.reviewboard.kde.org/r/128032/diff/


Testing
-------

Invoke:
$ krdc rdp://<your.favorite.rdp.host>

Without the 1. patch krdc converts the URL to vnc:// as seen in the windowTitle.
With the 1. patch, but without the 2., the RDP connection is opened, but the view is closed instantly by MainWindow::saveHostPrefs(), leaving the user with a new connection tab.
With both patches krdc works as expected.


Thanks,

Arno Möller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160529/111852a4/attachment.html>